From af2e6c7516f2be341cbc5630a8e7e3a78ea96d7c Mon Sep 17 00:00:00 2001
From: admin <admin@thebunkerops.ca>
Date: Wed, 16 Jul 2025 18:38:29 -0600
Subject: [PATCH] bug fixes for shifts functionality

---
 map/app/controllers/shiftsController.js | 3 ++-
 map/files-explainer.md                  | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/map/app/controllers/shiftsController.js b/map/app/controllers/shiftsController.js
index f1617d15..610b8023 100644
--- a/map/app/controllers/shiftsController.js
+++ b/map/app/controllers/shiftsController.js
@@ -160,8 +160,9 @@ class ShiftsController {
 
             // Calculate current volunteers dynamically
             let currentVolunteers = 0;
+            let allSignups = { list: [] }; // Initialize with empty list
             if (config.nocodb.shiftSignupsSheetId) {
-                const allSignups = await nocodbService.getAll(config.nocodb.shiftSignupsSheetId);
+                allSignups = await nocodbService.getAll(config.nocodb.shiftSignupsSheetId);
                 const confirmedSignups = (allSignups.list || []).filter(signup => 
                     signup['Shift ID'] === parseInt(shiftId) && signup.Status === 'Confirmed'
                 );
diff --git a/map/files-explainer.md b/map/files-explainer.md
index efefe383..63e045ab 100644
--- a/map/files-explainer.md
+++ b/map/files-explainer.md
@@ -44,7 +44,7 @@ Controller for application settings, start location, and walk sheet config.
 
 # app/controllers/shiftsController.js
 
-Controller for volunteer shift management (public and admin). When users sign up for shifts, the signup record includes the shift title for better tracking and display.
+Controller for volunteer shift management (public and admin). When users sign up for shifts, the signup record includes the shift title for better tracking and display. Fixed variable scope issue in signup method to prevent "allSignups is not defined" error.
 
 # app/controllers/usersController.js